Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add QM Panel to display info about js/css concatenation #5693

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Add QM Panel to display info about js/css concatenation #5693

wants to merge 7 commits into from

Conversation

trepmal
Copy link
Contributor

@trepmal trepmal commented Jul 2, 2024 •
edited
Loading

Description

Adds a QM panel for displaying debugging information about VIP's JS/CSS concatenation feature.

qm-concat-panel

Will not display any information without Automattic/nginx-http-concat#77

Changelog Description

Add "VIP JS/CSS Concat" Query Monitor Panel

Added

  • Add "VIP JS/CSS Concat" Query Monitor Panel

Removed

  • n/a

Fixed

  • n/a

Changed

  • n/a

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
  • This change works and has been tested on a sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

  • See also Add/qm compat nginx-http-concat#77. Helper plugin attached there, to ensure sufficient assets for logging.
  • Without above, this PR will simply create a "VIP JS/CSS Concat" panel with no data (shows "No data logged" message)

@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 101 lines in your changes missing coverage. Please review.

Project coverage is 29.39%. Comparing base (9a4423e) to head (238171a).
Report is 133 commits behind head on develop.

Files with missing lines Patch % Lines
...ugins/qm-vip-concat/class-qm-output-vip-concat.php 0.00% 72 Missing ⚠️
...ns/qm-vip-concat/class-qm-collector-vip-concat.php 0.00% 15 Missing ⚠️
qm-plugins/qm-vip-concat/qm-vip-concat.php 0.00% 12 Missing ⚠️
query-monitor.php 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #5693      +/-   ##
=============================================
- Coverage      29.51%   29.39%   -0.13%     
- Complexity      4779     4797      +18     
=============================================
  Files            282      285       +3     
  Lines          20587    20676      +89     
=============================================
  Hits            6077     6077              
- Misses         14510    14599      +89

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trepmal trepmal mentioned this pull request Jul 3, 2024
Open
@trepmal trepmal marked this pull request as ready for review July 3, 2024 19:03
@trepmal trepmal requested a review from a team as a code owner July 3, 2024 19:03
rinatkhaziev
rinatkhaziev reviewed Jul 24, 2024
View reviewed changes
qm-plugins/qm-vip-concat/class-qm-output-vip-concat.php
Comment on lines +12 to +13
add_filter( 'qm/output/menu_class', array( $this, 'admin_class' ) );
add_filter( 'qm/output/menus', array( $this, 'admin_menu' ), 101 );
Copy link
Contributor

@rinatkhaziev rinatkhaziev Jul 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to not display the panel altogether if there's no data (i.e. $data->logs is empty)?

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.3% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed.

This is an automation to keep pull requests manageable and actionable and is not a comment on the quality of this pull request nor on the work done so far. Closed PRs are still valuable to the project and their branches are preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rinatkhaziev rinatkhaziev rinatkhaziev left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trepmal @rinatkhaziev